search

BlueBrain / BluePyMM

Blue Brain Python Cell Model Management
https://bluepymm.readthedocs.io/en/latest/
Other
12 stars 9 forks source link

remove rows with none current #225

Closed arnaudon closed 1 year ago

arnaudon commented 3 years ago

Solving https://github.com/BlueBrain/BluePyMM/issues/222

There is already a flag to bypass this filtering, so I just did the simplest modif.

wvangeit commented 3 years ago

And for this flag. At the moment is not really working as expected. extra_value_errors should crash the code (but that was commented out). When extra_value_errors is false, we could ignore the rows and show a warning (that we're ignoring the row).

arnaudon commented 3 years ago

something like that?

arnaudon commented 3 years ago

The test breaks because the test run has None in extra_values, and the df is then empty, so it does not seem to save it, and thus a mismatch. Not sure how to make the extra_values not None in the tests.

jdcourcol commented 2 years ago

@arnaudon , may be we should try to complete that , no ? since it seems you made 90% of the work already :)

arnaudon commented 2 years ago

Ah, as you wish, I'm not using BluePyEMM anymore.

jdcourcol commented 2 years ago

It is more like I would prefer that problem not to happen anymore. If we are not going to use bluepymm anymore that is fine though. Let's see what @wvangeit thinks about that.

wvangeit commented 2 years ago

Discussed this with @arnaudon this morning. He actually meant he's not using bluepymm atm. But e.g. for sscx it would be good to have this solved.