BlueBrain / BluePyMM

Blue Brain Python Cell Model Management
https://bluepymm.readthedocs.io/en/latest/
Other
12 stars 9 forks source link

Make skip_repair_examplars skip all examplars? #226

Closed arnaudon closed 3 years ago

arnaudon commented 3 years ago

@alex4200 noticed that if we don't have the exemplar morphs in the morph release MM complains even with skip_repair_examplars:

https://github.com/BlueBrain/BluePyMM/blob/master/bluepymm/prepare_combos/create_mm_sqlite.py#L118

maybe we can move this if further up to not even try to load repaired exemplar?

wvangeit commented 3 years ago

do we know where it complains exactly?

arnaudon commented 3 years ago

Here: https://github.com/BlueBrain/BluePyMM/blob/master/bluepymm/prepare_combos/create_mm_sqlite.py#L136

wvangeit commented 3 years ago

Isn't that line 'protected' by skip_repair_examplars?

arnaudon commented 3 years ago

my bad, this one: https://github.com/BlueBrain/BluePyMM/blob/master/bluepymm/prepare_combos/create_mm_sqlite.py#L115

wvangeit commented 3 years ago

Ok, but so that's a different case, i.e. it checks the 'unrepaired' morph. Imo this morph should always be available, so that we can test a run with the original morphology. The skip_repair_examplars is just there in case the unrepaired examplar is not sure to survive the repair process (which is not guaranteed).

arnaudon commented 3 years ago

Ah yes, you are right. Indeed, the issue was that @alex4200 tests had missing exemplars, so it was crashing here. I agree we should have these morphs available, but I naively thought that this option would also not require them. All cleared then! Thanks!