BlueBrain / BluePyMM

Blue Brain Python Cell Model Management
https://bluepymm.readthedocs.io/en/latest/
Other
12 stars 9 forks source link

remove dependency to neurondb.xml #63

Open jdcourcol opened 7 years ago

jdcourcol commented 7 years ago

This file is a BBP internal format. It may also contains informations that are unrelated to bluepymm such as repair instructions. We should have a much simpler format for the end user.

liesbethvanherpe commented 7 years ago

Currently, the "neurondb.xml" input is parsed into a list of (name, fullmtype, mtype, msubtype, layer)-tuples.

wvangeit commented 7 years ago

for this we should solve the file-extension issue. Problem is that at the moment we don't have any info about the file extensions, preventing the use of swc files.

jdcourcol commented 7 years ago

do we need to have the file extension in the file ? can we just have a list of tuple (name, layer, mtype, msubtype) ?

wvangeit commented 7 years ago

Doesn't it really matter how we get it, but the morph release should communicate to us the file extension in some way. But to me this input file seems to be the right location for that. I wouldn't be surprised e.g. if hippocampus could have mix of swc and asc in same release

jdcourcol commented 7 years ago

What we want to express here are the morphological properties for each morphology. This is independent of the representation of the morphology (.asc, .swc..).

I would rather have additional parameters that give us the source (input directory, neuroinformatics URL later) and one that give us the preferred representation (.asc, .swc...)

To sum up, I prefer to separate the 2 concerns: morphology properties and how we load the morphology

wvangeit commented 7 years ago

Ok, so it means we need another input file with the extensions of every morphology.

jdcourcol commented 7 years ago

no, just a parameter that says which extension which should use. and we can default to '.asc' so that it is optional in most case

wvangeit commented 7 years ago

and how do we do that with mixed morphologies ?

liesbethvanherpe commented 7 years ago

Latest update:

[
{ "morphname": "morph1", "dirname": ".", "extension": "asc", "mtype": "mtype1", "layer": "1" }, { "morphname": "morph2", "extension": "asc", "mtype": "mtype2", "layer": "2" } ]

where "dirname" is optional with "." as a default value.

liesbethvanherpe commented 7 years ago

See #139