BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
199 stars 97 forks source link

Stochastic mech features #397

Closed AurelienJaquier closed 2 years ago

AurelienJaquier commented 2 years ago
DrTaDa commented 2 years ago

@wvangeit this is something that was implemented for BluePyEModel but we thought it might be better in BluePyOpt

DrTaDa commented 2 years ago

@AurelienJaquier it makes me think, maybe all of the stochastic logic could be brought to BluePyOpt. We should have a look.

AurelienJaquier commented 2 years ago

@DrTaDa Do you mean the logic in the run() method of BPEM_Protocol? Or were you thinking of something else?

wvangeit commented 2 years ago

Should the pre_protocol change the value to deterministic, run it, and set it back to the old value?

DrTaDa commented 2 years ago

@DrTaDa Do you mean the logic in the run() method of BPEM_Protocol? Or were you thinking of something else?

@AurelienJaquier yes, this part.

The only part left in BPEM would be the instantiation of the simulator, stochastic or not. But maybe that part can also be put in the BluePyOpt simulator class.

AurelienJaquier commented 2 years ago

Ok, I'll try both your ideas.

DrTaDa commented 2 years ago

Looks good to me