search

BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
199 stars 97 forks source link

Fix tests CMA #406

Closed DrTaDa closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #406 (748353f) into master (dd5713d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   90.49%   90.49%           
=======================================
  Files          41       41           
  Lines        2473     2473           
=======================================
  Hits         2238     2238           
  Misses        235      235

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd5713d...748353f. Read the comment docs.

DrTaDa commented 2 years ago

@wvangeit to fix the issue with #393

wvangeit commented 2 years ago

I see that there are quite a few changes in examples/l5pc/mechanisms/ProbAMPANMDA_EMS.mod and GABA. I think we don't use these files? Maybe it's better to just remove these from the repo

wvangeit commented 2 years ago

Same for stochkv and stochkv3, we probably only use 1 of these? Best to remove the one we don't use.

DrTaDa commented 2 years ago

We use both in the examples/stochkv

wvangeit commented 2 years ago

Ok, but not the synapse files i assume, right?

DrTaDa commented 2 years ago

Yes, I removed these