Closed musicinmybrain closed 1 year ago
So they basically dropped Py 3.7 support I guess?
Ah yes 3.8 works, shall we drop 3.7 as well?
It depends a bit on how common py 3.7 is still used at the moment. Do you know what the default python in ubuntu LTS at the moment?
Python3.7 ends in 4 months. https://endoflife.date/python
Ubuntu LTS (22.04) comes with python3.10.4. https://utcc.utoronto.ca/~cks/space/blog/python/Ubuntu2204PythonState
Ok, if it ends in 4 months it's ok, we can already drop the support.
https://github.com/BlueBrain/BluePyOpt/pull/446 is created to drop py3.7 support.
Merging #445 (10079ae) into master (e65e5f7) will increase coverage by
1.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
+ Coverage 86.68% 87.87% +1.18%
==========================================
Files 50 50
Lines 4288 4288
==========================================
+ Hits 3717 3768 +51
+ Misses 571 520 -51
Impacted Files | Coverage Δ | |
---|---|---|
bluepyopt/ephys/locations.py | 86.95% <0.00%> (+0.48%) |
:arrow_up: |
bluepyopt/ephys/stimuli.py | 88.60% <0.00%> (+1.26%) |
:arrow_up: |
bluepyopt/deapext/utils.py | 96.87% <0.00%> (+1.56%) |
:arrow_up: |
bluepyopt/ephys/simulators.py | 83.66% <0.00%> (+9.80%) |
:arrow_up: |
bluepyopt/ephys/protocols.py | 72.92% <0.00%> (+11.55%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thank you @musicinmybrain for your contribution!
The CI failure is not related to this PR, it's because of the following release of NEURON-nightly:
NEURON-nightly 9.0.dev1289
.