search

BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
198 stars 96 forks source link

Update l5pc example benchmark for numpy.float deprecation #445

Closed musicinmybrain closed 1 year ago

anilbey commented 1 year ago

The CI failure is not related to this PR, it's because of the following release of NEURON-nightly: NEURON-nightly 9.0.dev1289.

wvangeit commented 1 year ago

So they basically dropped Py 3.7 support I guess?

anilbey commented 1 year ago

Ah yes 3.8 works, shall we drop 3.7 as well?

wvangeit commented 1 year ago

It depends a bit on how common py 3.7 is still used at the moment. Do you know what the default python in ubuntu LTS at the moment?

anilbey commented 1 year ago

Python3.7 ends in 4 months. https://endoflife.date/python

Ubuntu LTS (22.04) comes with python3.10.4. https://utcc.utoronto.ca/~cks/space/blog/python/Ubuntu2204PythonState

wvangeit commented 1 year ago

Ok, if it ends in 4 months it's ok, we can already drop the support.

anilbey commented 1 year ago

https://github.com/BlueBrain/BluePyOpt/pull/446 is created to drop py3.7 support.

codecov-commenter commented 1 year ago

Codecov Report

Merging #445 (10079ae) into master (e65e5f7) will increase coverage by 1.18%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   86.68%   87.87%   +1.18%     
==========================================
  Files          50       50              
  Lines        4288     4288              
==========================================
+ Hits         3717     3768      +51     
+ Misses        571      520      -51
Impacted Files Coverage Δ
bluepyopt/ephys/locations.py 86.95% <0.00%> (+0.48%) :arrow_up:
bluepyopt/ephys/stimuli.py 88.60% <0.00%> (+1.26%) :arrow_up:
bluepyopt/deapext/utils.py 96.87% <0.00%> (+1.56%) :arrow_up:
bluepyopt/ephys/simulators.py 83.66% <0.00%> (+9.80%) :arrow_up:
bluepyopt/ephys/protocols.py 72.92% <0.00%> (+11.55%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wvangeit commented 1 year ago

Thank you @musicinmybrain for your contribution!