search

BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
198 stars 96 forks source link

Fix tsodyksmarkramstp example #458

Closed AurelienJaquier closed 1 year ago

AurelienJaquier commented 1 year ago

Solves Issue #457

codecov-commenter commented 1 year ago

Codecov Report

Merging #458 (0b1675d) into master (890c14e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          50       50           
  Lines        4323     4323           
=======================================
  Hits         3780     3780           
  Misses        543      543
AurelienJaquier commented 1 year ago

Yeah. it is called during optimisation, assuming the evaluator is a Cellevaluator, which has a simulator and this method. So for the other evaluators, we have to create this function, even if it is just calling evaluate_with_lists.