BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
198 stars 96 forks source link

remove ineffective checks against python2 #462

Closed anilbey closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #462 (ece9a52) into master (c210d67) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   87.41%   87.43%   +0.02%     
==========================================
  Files          50       50              
  Lines        4330     4321       -9     
==========================================
- Hits         3785     3778       -7     
+ Misses        545      543       -2     
Impacted Files Coverage Δ
bluepyopt/ephys/serializer.py 100.00% <ø> (ø)
bluepyopt/ephys/models.py 87.79% <100.00%> (+0.40%) :arrow_up:
anilbey commented 1 year ago

@wvangeit I think only you have the authority to merge

wvangeit commented 1 year ago

Is there any specific reason to remove these lines, apart from readability? I don't really feel like breaking compatibility just for the sake of breaking compatibility. I'm just worried there might be some users using notebooks on old systems etc.

anilbey commented 1 year ago

No, only readability and a bit of confusion :) E.g. from __future__ is not the future but the past now

wvangeit commented 1 year ago

Ok, but I don't consider that enough arguments to possibly break external user's scripts.

anilbey commented 1 year ago

Ok, sure. I'm closing.