BlueBrain / BluePyOpt

Blue Brain Python Optimisation Library
https://bluepyopt.readthedocs.io/en/latest/
Other
198 stars 96 forks source link

remove __future__ imports #473

Closed AurelienJaquier closed 11 months ago

AurelienJaquier commented 11 months ago

I only removed one line in each jupyter notebook, and it does not look like anything else has changed, when checking visually. @anilbey do you know why other lines have been unilateraly changed here?

anilbey commented 11 months ago

Nice change.

Yeah jupyter and git do these. Those differences must be created after you execute the cells.

anilbey commented 11 months ago

So I think if you git reset and then remove the lines and not execute the notebook cells then it should not add those.

AurelienJaquier commented 11 months ago

I actually did not execute the cells. I just removed the line, and saved in VScode.

anilbey commented 11 months ago

Oh, I see. Hmm if vscode did something and not displayed it, then the javascript lines can still be selected via git add -p PATH_TO_NOTEBOOK if you want to remove them.

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (f7fd66d) 87.31% compared to head (8c8fb4b) 87.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #473 +/- ## ======================================= Coverage 87.31% 87.31% ======================================= Files 50 50 Lines 4336 4329 -7 ======================================= - Hits 3786 3780 -6 + Misses 550 549 -1 ``` | [Files](https://app.codecov.io/gh/BlueBrain/BluePyOpt/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [bluepyopt/deapext/tools/selIBEA.py](https://app.codecov.io/gh/BlueBrain/BluePyOpt/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-Ymx1ZXB5b3B0L2RlYXBleHQvdG9vbHMvc2VsSUJFQS5weQ==) | `100.00% <100.00%> (ø)` | | | [bluepyopt/ephys/serializer.py](https://app.codecov.io/gh/BlueBrain/BluePyOpt/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-Ymx1ZXB5b3B0L2VwaHlzL3NlcmlhbGl6ZXIucHk=) | `100.00% <ø> (ø)` | | | [bluepyopt/ipyp/bpopt\_tasksdb.py](https://app.codecov.io/gh/BlueBrain/BluePyOpt/pull/473?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-Ymx1ZXB5b3B0L2lweXAvYnBvcHRfdGFza3NkYi5weQ==) | `0.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.