BlueBrain / Brayns

Visualizer for large-scale and interactive ray-tracing of neurons
GNU Lesser General Public License v3.0
291 stars 47 forks source link

BRAYNS 572 - Replace glm with rkcommon math #1198

Closed NadirRoGue closed 1 year ago

NadirRoGue commented 1 year ago

Replaces GLM with rkcommon::math utilities.

TestGeometries - test_geometry_plane test and asset had to be updated. The test was on a corner case, where a plane (the red one) was perfectly aligned with the light direction. Small floating point precision differences between the transform matrix of GLM and rk common (starting at the 6th decimal position on wards) was creating a disparity on the test reference image: for GLM, the planes were not casting shadows on each other, for rk common, the red plane was casting shadow on the white plane. To avoid these issues, the test has been updated to not align the red plane with the light direction, and the reference image has been updated accordingly.