[ ] Rename the file as Dockerfile or deep_atlas.Dockerfile (w/o the Dockerfile extension, the file format is not recognized)
[ ] Add functionalities to create users and run the Docker image as a non-root user[^1] (e.g. see what done in morphoclasshere). In general, running Docker images as root is quite dangerous, and allows the creation of files that then are impossible to remove (unless you're root).
[ ] Move all Docker-related files and scripts under a docker/ directory (e.g. see what done in morphoclasshere).
[ ] Add instructions on how to use Docker in the README.md (e.g. something like this text).
[ ] Test that docker build and docker run work on Apple M1.
[^1]: Note that this is necessary only when running the image with docker. When running with singularity (see #50), the system should take automatically care of providing the user in the running container with limited read/write access rights, corresponding to the rights usually has. So there should be (to be verified!) no need for --user when doing singularity run.
A few ideas for improving our Docker setup.
Dockerfile
ordeep_atlas.Dockerfile
(w/o theDockerfile
extension, the file format is not recognized)root
user[^1] (e.g. see what done inmorphoclass
here). In general, running Docker images asroot
is quite dangerous, and allows the creation of files that then are impossible to remove (unless you'reroot
).docker/
directory (e.g. see what done inmorphoclass
here).README.md
(e.g. something like this text).docker build
anddocker run
work on Apple M1.[^1]: Note that this is necessary only when running the image with
docker
. When running withsingularity
(see #50), the system should take automatically care of providing the user in the running container with limited read/write access rights, corresponding to the rights usually has. So there should be (to be verified!) no need for--user
when doingsingularity run
.