search

BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
673 stars 159 forks source link

Make `~Object` protected. #1009

Closed 1uc closed 3 months ago

1uc commented 3 months ago

Since deleting HighFive objects through their common base class Object is not supported, we should make the dtor protected.

See Core Guidelines C35, e.g. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.81%. Comparing base (adf6b05) to head (b5c7059).

Files Patch % Lines
include/highfive/bits/h5o_wrapper.hpp 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1009 +/- ## ========================================== - Coverage 86.82% 86.81% -0.01% ========================================== Files 100 100 Lines 6080 6083 +3 ========================================== + Hits 5279 5281 +2 - Misses 801 802 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

1uc commented 3 months ago

Closes #1008.