search

BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
673 stars 159 forks source link

Refactor H5Easy to use core. #1016

Closed 1uc closed 2 months ago

1uc commented 3 months ago

Removes all custom implementations for serializing Eigen, XTensor, OpenCV, std::vector and uses HighFive core instead.

This allows us to remove most specialization, except the one for Eigen which serializes Matrix<double, 1, -1> as a one-dimensional array and reads it from one- or two-dimensional data.

1uc commented 3 months ago

Note that it's current based on top of #1011.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (cb77ede) to head (ca6cba3).

Files Patch % Lines
include/highfive/h5easy_bits/H5Easy_scalar.hpp 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1016 +/- ## ========================================== + Coverage 86.72% 86.78% +0.05% ========================================== Files 102 101 -1 Lines 6043 5964 -79 ========================================== - Hits 5241 5176 -65 + Misses 802 788 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.