search

BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
673 stars 159 forks source link

Request support for boost::span #1024

Open Arsennnic opened 2 months ago

Arsennnic commented 2 months ago

I use boost::span as an alternative to std::span since I'm limited to C++17. boost::span has been introduced in Boost core since Boost-1.78, which is a compatible implementation of std::span.

Would you please and the support for boost::span?

Alternatively, would you mind if I refer to the code in <highfive/span.hpp>, implement this feature by myself, and open a pull request?

1uc commented 2 months ago

Thank you, nice idea. We implemented it in #1025 but since boost::span is a very recent addition, the Boost version installed in the CI image (and I believe commonly on Ubuntu) is too old, i.e. v71.

Finishing the implementation would require splitting boost.hpp. Then setting up special CI to check against more modern versions of boost and finally make the automated tests aware of the boost version available so the can avoid testing boost::span iff it's not available.

You're likely better off forking or submoduling a particular SHA until we can finish the rest.

Arsennnic commented 2 months ago

Thanks!