BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
687 stars 161 forks source link

Pass dimensions to 'serialize'. #939

Closed 1uc closed 8 months ago

1uc commented 9 months ago

By passing the dimensions to serialize allows serializing nested pointers. This was previously not possible because, we didn't know how many elements the pointer pointed to.

The logic for obtaining the dimensions of the array is:

Therefore, if we perform a write without selection, we know the dimensions the input array must have. If we perform a selection we again know the dimensions the input buffer needs to have.

1uc commented 9 months ago

Since it changes the inspector, we should probably not merge this into v2.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f32d186) 84.55% compared to head (c28af89) 84.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #939 +/- ## ======================================= Coverage 84.55% 84.55% ======================================= Files 86 86 Lines 5220 5220 ======================================= Hits 4414 4414 Misses 806 806 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.