Closed 1uc closed 8 months ago
Since it changes the inspector, we should probably not merge this into v2
.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f32d186
) 84.55% compared to head (c28af89
) 84.55%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
By passing the dimensions to
serialize
allows serializing nested pointers. This was previously not possible because, we didn't know how many elements the pointer pointed to.The logic for obtaining the dimensions of the array is:
When creating/opening the array the memspace is set to be the same as the filespace.
Performing a selection either leads to a simple (packed) multi-dimensional memspace; or to a one-dimensional memspace.
Therefore, if we perform a write without selection, we know the dimensions the input array must have. If we perform a selection we again know the dimensions the input buffer needs to have.