BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
687 stars 161 forks source link

Review Chunking in Easy. #972

Closed 1uc closed 8 months ago

1uc commented 8 months ago

Checking the uncovered lines of code lead to the following line: https://github.com/BlueBrain/HighFive/blob/e54d176be806c60aa9d61e333912934cc6dfa3cc/include/highfive/h5easy_bits/H5Easy_misc.hpp#L52-L57

~At a glance they look suspicious, because it's possible to have chunks that aren't the size of the dataset.~ They just can't exceed the maximum size per dimension.