BlueBrain / HighFive

HighFive - Header-only C++ HDF5 interface
https://bluebrain.github.io/HighFive/
Boost Software License 1.0
673 stars 159 forks source link

Assert that XTensor objects are row-major. #989

Closed 1uc closed 4 months ago

1uc commented 4 months ago

Easy serializes XTensor objects by obtaining a pointer to the first element, and then using write_raw. Same for reading using read_raw.

Therefore, it only supports (a subset of) row-major arrays. This commit as a runtime check.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.38%. Comparing base (c1b3cde) to head (0c2fe58). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #989 +/- ## ======================================= Coverage 86.38% 86.38% ======================================= Files 92 92 Lines 5898 5898 ======================================= Hits 5095 5095 Misses 803 803 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.