search

BlueBrain / Livre

Large-scale Interactive Volume Rendering Engine
https://bluebrain.github.io
GNU Lesser General Public License v3.0
32 stars 21 forks source link

Cleanups #403

Closed eile closed 7 years ago

eile commented 7 years ago

the engine class looks like an empty shell now, not sure why.

Why (for me): Because it's just the plumbing service <-> client. Maybe it can be merged into Client later?

eile commented 7 years ago

not sure why the EventHandler class was removed, it looked more appropriate than having the Config class do event handling.

It was (imo) a pointless separation Ahmet insisted on. In Eq, classes (Config, View, Channel) handle events directly, instead of having a separate abstraction. This has benefits (data modified by event handling is typically managed by the entity) and obvious drawbacks. In any case, due to the necessary CRTP coupling between config and EH (actual hierarchy was livre::Config <- EventHandler <- eq::Config), no decoupling was actually gained.