search

BlueBrain / Monsteer

Interactive Supercomputing Tools and Library
http://bluebrain.github.io/
GNU Lesser General Public License v3.0
4 stars 7 forks source link

Move old SDK/Monsteer spike report to brain #27

Closed eile closed 8 years ago

eile commented 8 years ago

See BlueBrain/Brion#63

rdumusc commented 8 years ago

tests/spikeReportReaderWriter.cpp should be moved as well, good otherwise

eile commented 8 years ago

No, the test needs the monsteer brion plugin. I considered it too. ;)

rdumusc commented 8 years ago

I am looking at it for the second time and I don't see where the plugin is needed. If one of the individual tests needs it it then it should be moved to spikeStreamReport.cpp. It is not right that the classes moved to brion rely on unit tests from a different project.

eile commented 8 years ago

Ok, will look into it.

rdumusc commented 8 years ago

+1 now that the unit test has been moved along with the classes. I thought that changelog entries + version bumps were the norm for such changes, both here and in Brion, but up to you.

eile commented 8 years ago

changelog entries + version bumps

I don't know. On one hand, I would not consider this a stable API yet, so don't draw too much attention to it. On the other hand, it changes the API (namespace only here). Definitely need to bump version.

What is your opinion?

@bilgili: You were working on this class? Shall I wait with this merge?

rdumusc commented 8 years ago

+1 for version bump to Monsteer 0.5.0 as many classes / functions were removed from the Project.

I don't see a changelog entry as a way of drawing attention, but simply documenting the list of non-trivial changes so that people have an easy way to see what happened between 2 releases.

Were you talking about the API about the ABI? Technically ABI has changed as well but this is not so important. I am not sure what rule we decided to follow for unstable projects (version_major == 0), but most of the time it follows version_minor because it is unstable and changes constantly. We could also decide to keep version ABI = 1 constant for those projects.