BlueBrain / MorphIO

A python and C++ library for reading and writing neuronal morphologies
https://morphio.readthedocs.io
Apache License 2.0
26 stars 22 forks source link

Path/permission issues during installation. #472

Closed 1uc closed 9 months ago

1uc commented 12 months ago

After e75d9f459e3353e9a70faf1e791fa53241cc106e I see permission related failure when installing MorphIO. The steps to reproduce the issue are:

$ cmake -DCMAKE_INSTALL_PREFIX=build/install -DMorphIO_WERROR=Off -B build .
$ cmake --build build --parallel --target install
...
Install the project...
/usr/bin/cmake -P cmake_install.cmake
-- Install configuration: "RelWithDebInfo"
-- Installing: /home/lucg/git/bbp/MorphIO/build/install/include
...
-- Installing: /home/lucg/git/bbp/MorphIO/build/install/lib/libmorphio.so
CMake Error at binds/python/cmake_install.cmake:60 (file):
  file cannot create directory: /usr/lib/python3.11/site-packages/morphio.
  Maybe need administrative privileges.
Call Stack (most recent call first):
  cmake_install.cmake:80 (include)
1uc commented 12 months ago

See https://github.com/BlueBrain/MorphIO/pull/473

mgeplf commented 11 months ago

Sorry, I haven't had time to look at this yet :(

mgeplf commented 9 months ago

I tried to replicate this, but I didn't have any luck. I used the quay.io/pypa/manylinux2014_x86_64 docker image ( CentOS 7 based), and installed used the above commands as a non-root user:

gmake[1]: Entering directory `/home/test/morphio/MorphIO/build'
gmake[1]: Nothing to be done for `preinstall'.
gmake[1]: Leaving directory `/home/test/morphio/MorphIO/build'
Install the project...
/opt/_internal/pipx/venvs/cmake/lib/python3.10/site-packages/cmake/data/bin/cmake -P cmake_install.cmake
-- Install configuration: "RelWithDebInfo"
...[snip]...
-- Installing: /home/test/morphio/MorphIO/build/install/lib64/libmorphio.so.0.0.0
-- Set runtime path of "/home/test/morphio/MorphIO/build/install/lib64/libmorphio.so.0.0.0" to ""
-- Installing: /home/test/morphio/MorphIO/build/install/lib64/libmorphio.so

@1uc do you have more info on what system you were using, along w/ the environment (ie: was it a virtualenv or something?)

1uc commented 9 months ago

@mgeplf we fixed this a while ago: https://github.com/BlueBrain/MorphIO/commit/bdccf36a3fdf5d3e447d577c84b8d9ac5584b212

I confirmed current master works locally and on the cluster.

mgeplf commented 9 months ago

Thanks.