BlueBrain / NeuroM

Neuronal Morphology Analysis Tool
https://neurom.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
103 stars 55 forks source link

NeuroM 3.0 #918

Closed asanin-epfl closed 3 years ago

asanin-epfl commented 3 years ago

NeuroM seriously confuses concepts of Neuron and Morphology. Everything that currently has a name neuron or Neuron must be changed to morphology and Morphology. This way NeuroM can be clearly used for any topological entity like: Neuron, Glial cell, Vasculature cell, etc.

I suggest a huge renaming of neuron to morphology and release NeuroM 3.0 with this change.

eleftherioszisis commented 3 years ago

Although it is a good idea to generalize the morphological entity, we need to keep in mind that each family of cells may have their own unique features that depend on extra datasets (e.g. perimeters in astrocytes).

As far as the vasculature is concerned, I believe it is out of the scope of this package because it is a cyclic graph without a specific root, therefore it is quite different and its features may require specialized mechanics.

asanin-epfl commented 3 years ago

Thank you so much for feedback @eleftherioszisis.

Unique features are not the problem. NeuroM still can have subclasses for Neuron, Astrocyte, etc. The head of these classes will be Morphology.

eleftherioszisis commented 3 years ago

Morphology is a good generic name for any sort of entity that can be represented as cross-sections (points + diameters) linked together by segments. Therefore, neurons, glia, spines, and vasculature are all morphologies.

IMHO Graph does not imply an embedding in the euclidean space. A social network for instance can be a graph, but it does not fit the criteria for being a Morphology.

asanin-epfl commented 3 years ago

Thank you for clarifying.

arnaudon commented 3 years ago

This is going to break again several tools ;) But +1 for being consistent in naming these.