search

BlueBrain / NeuroTS

Topological Neuron Synthesis
https://neurots.readthedocs.io/en/stable
Apache License 2.0
36 stars 5 forks source link

Fix: Explicitly write soma type #77

Closed arnaudon closed 1 year ago

arnaudon commented 1 year ago

solves #76

codecov[bot] commented 1 year ago

Codecov Report

Merging #77 (2968da5) into main (c65ffc8) will increase coverage by 0.09%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #77 +/- ## ========================================== + Coverage 97.59% 97.69% +0.09% ========================================== Files 39 39 Lines 2159 2165 +6 Branches 332 334 +2 ========================================== + Hits 2107 2115 +8 + Misses 35 30 -5 - Partials 17 20 +3 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/NeuroTS/pull/77/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/BlueBrain/NeuroTS/pull/77/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `97.69% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/BlueBrain/NeuroTS/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [neurots/generate/grower.py](https://app.codecov.io/gh/BlueBrain/NeuroTS/pull/77?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-bmV1cm90cy9nZW5lcmF0ZS9ncm93ZXIucHk=) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/BlueBrain/NeuroTS/pull/77/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain)
arnaudon commented 1 year ago

I don't get why the try is not covered, as it crashed here: https://github.com/BlueBrain/NeuroTS/actions/runs/6037160854/job/16380883990