BlueBrain / atlas-densities

Tools to compute densities in the context of brain atlases.
Apache License 2.0
3 stars 8 forks source link

Csv update #36

Closed dkeller9 closed 8 months ago

dkeller9 commented 1 year ago

I have made the change to L3_TPC:B in the csv file. Not sure if it will break other things in the entire pipeline though.

mgeplf commented 1 year ago

@lecriste did you run this with the pipeline? What is the difference in the densities that are output?

lecriste commented 1 year ago

Not yet, will run it asap and provide the new densities set.

lecriste commented 1 year ago

I reproduced these excitatory split densities with both the previous and the new csv version and the output files are identical (apart from the obvious change in the filename from "L3_TPC:B_cADpyr.nrrd" to "L3_TPC:C_cADpyr.nrrd"). If we are happy with the new "L3TPC:C" MType (currently resolved as below), I think we can update the [csv file in Nexus](https://staging.nise.bbp.epfl.ch/nexus/v1/resources/bbp/atlas//6419ac24-9d62-494f-b405-56f00743fcde?rev=1).

forge.resolve("L3_TPC:C", scope="ontology", target="terms", strategy="EXACT_MATCH")
{
id='http://bbp.epfl.ch/neurosciencegraph/ontologies/mtypes/RHYUdxH7spioam6E9haPwu',
label='L3_TPC:C',
prefLabel='Layer 3 Narrow Tufted Pyramidal Cell',
subClassOf='http://uri.interlex.org/base/ilx_0738384')
}
lecriste commented 1 year ago

The Nexus file is updated and the next run of the Atlas pipeline will use the fixed label. This can be merged on my side.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1ad5b35). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage        ?   97.74%           
=======================================
  Files           ?       22           
  Lines           ?     1374           
  Branches        ?        0           
=======================================
  Hits            ?     1343           
  Misses          ?       31           
  Partials        ?        0           
Flag Coverage Δ
pytest 97.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.