BlueBrain / atlas-densities

Tools to compute densities in the context of brain atlases.
Apache License 2.0
2 stars 7 forks source link

add `--region-name` as an option to `fit-average-densities` #45

Closed mgeplf closed 11 months ago

mgeplf commented 11 months ago
mgeplf commented 11 months ago

@lecriste have you had a chance to try this, and see if it fixed the issue with renaming in the hierarchy?

lecriste commented 11 months ago

Not yet.

mgeplf commented 11 months ago

Ok, let me know when you have a chance.

lecriste commented 11 months ago

@mgeplf, I confirm this fixes the issue.

mgeplf commented 11 months ago

@mgeplf, I confirm this fixes the issue.

Excellent. That means that we don't need the change in https://github.com/BlueBrain/atlas-densities/pull/42 correct? Can we close that?

lecriste commented 11 months ago

@mgeplf, I confirm this fixes the issue.

Excellent. That means that we don't need the change in #42 correct? Can we close that?

Let me confirm when the current run of the pipeline completes.

lecriste commented 11 months ago

@mgeplf, we need to customize also this root value: https://github.com/BlueBrain/atlas-densities/blob/db30d0b4c7d6b6356dcf48a766ffd98a18ac9248/atlas_densities/densities/inhibitory_neuron_densities_optimization.py#L612

mgeplf commented 11 months ago

@mgeplf, we need to customize also this root value:

Please try https://github.com/BlueBrain/atlas-densities/pull/46 and let me know if it works

lecriste commented 11 months ago

It works.