search

BlueBrain / atlas-densities

Tools to compute densities in the context of brain atlases.
Apache License 2.0
2 stars 7 forks source link

Leaf region will only trigger if the region exists #48

Open cveraszto opened 10 months ago

cveraszto commented 10 months ago

This is a more generic solution to what was tested by Leo. The issue with the same conditions will only trigger if the region actually exist.

mgeplf commented 10 months ago

@cveraszto I have fixed the linting errors and such, but I will need you to update the test so that it makes sense for the changes that were made: https://github.com/BlueBrain/atlas-densities/actions/runs/6183250760/job/16784618215?pr=48#step:5:61

cveraszto commented 10 months ago

@cveraszto I have fixed the linting errors and such, but I will need you to update the test so that it makes sense for the changes that were made: https://github.com/BlueBrain/atlas-densities/actions/runs/6183250760/job/16784618215?pr=48#step:5:61

Ah, this is important! I will get to this! We can't have 0 values for deltas because that would mean the x_result can't be optimised, as there is no room for standard deviation around a cell count.