BlueBrain / atlas-densities

Tools to compute densities in the context of brain atlases.
Apache License 2.0
3 stars 8 forks source link

Drop literature values from regions that are not in hierarchy or not in the annotation volume #61

Closed drodarie closed 8 months ago

drodarie commented 8 months ago

Fix #60. Regions dropped will be displayed with a warning. Update README.rst

mgeplf commented 8 months ago

Thanks! I've asked @lecriste to try this, and see if it fixes the issue. If it works, I can have a look at fixing the tests.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@67d273c). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ======================================= Coverage ? 97.78% ======================================= Files ? 22 Lines ? 1447 Branches ? 0 ======================================= Hits ? 1415 Misses ? 32 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/atlas-densities/pull/61/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/BlueBrain/atlas-densities/pull/61/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `97.78% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drodarie commented 8 months ago

@mgeplf I solved the tests issues. It was linked to the root region parameter. The code should be ready to review now.

mgeplf commented 8 months ago

Great; thanks - I'll wait to merge it until we see if it fixes the atlas issue.

mgeplf commented 8 months ago

Thanks @drodarie; very appreciated.