BlueBrain / atlas-densities

Tools to compute densities in the context of brain atlases.
Apache License 2.0
3 stars 8 forks source link

allow skipping normalization when `compute_cell_density` #70

Closed mgeplf closed 6 months ago

mgeplf commented 7 months ago

@lecriste and @Sebastien-PILUSO can you try this, and see if it solves the problem you were running into?

drodarie commented 7 months ago

I have a counter proposal for this pull request. The issue happened because the outside of the Nissl used is set to 0. Why not solving the issue in the function normalize_intensity in utils.py? I can provide a simple implementation.

Sebastien-PILUSO commented 7 months ago

@drodarie why would you like to still apply thenormalize_intensity function when all the processings applied in it are already applied to the input volume?

drodarie commented 7 months ago

Then the function will not do anything and that's fine. This way, we don't have an extra user option which would make the pipeline even more difficult to use.

drodarie commented 7 months ago

See my proposal here

mgeplf commented 7 months ago

See my proposal here

If that's what you want, that works for me. I very much prefer fewer options that modify the behavior (ie: I agree with what you on we don't have an extra user option...)

Sebastien-PILUSO commented 7 months ago

Ok let's try

Sebastien-PILUSO commented 7 months ago

I ran the code using @drodarie's branch and this gave the same cell density file than on the main branch. So this is okay for me.

mgeplf commented 6 months ago

Done better in #74