Closed drodarie closed 3 months ago
For some reason, the tests for the mtype step are now failing: test_mtype_densities.py
However, I do not see how any of my changes impacted these tests.
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
main@2b89cfd
). Click here to learn what that means.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
However, I do not see how any of my changes impacted these tests.
I fixed that in https://github.com/BlueBrain/atlas-densities/pull/76
Code looks good, I have to assume it's correct from the scientific standpoint. Reportedly, this has been used for the latest atlas release in staging (https://bbpteam.epfl.ch/project/issues/browse/BBPP134-1342?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=239469#comment-239469)
This pull request fixes 3 different issues in the fitting and inhibitory optimization steps: