Open asoplata opened 5 months ago
@arnaudon Can you please check that PR #18 passes the tests in an environment where Ultraliser is loaded? I strongly suspect that that's the core issue
I just confirmed that this same test passes if I use https://github.com/BlueBrain/atlas-placement-hints/commit/337623b917d45054be0de5781de23cc6f60ba195 and load an old version of ultraliser v0.1.0 from 2020-01 , so it's almost certainly that change
yes, you are likely right, but I don't like the oversmoothing of ultraliser, I prefer using a simple marching cube algo, as I was experimenting with cerebellum. It seems your test above is lower quality mesh, but I have no idea how/why. It will be easier to just not use ultraliser than trying to debug that tbh (which is very not interesting debug at all). I'm not part of atlas 'team' nor atlas meetings, so I have not my say in this. If this is an issue, feel free to revert this commit to previous ultraliser version. I'm not using the new version anyway, once I realised what this was doing ;)
if I use the latest
main
branch, avenv
that @mgeplf created, and the unstable version of Ultraliser on BB5, certain tests do not pass. In particular, if I runpytest tests/app/test_placement_hints.py::test_thalamus
, I get the following input, which has been edited:Note that when I ran
pytest
before Ultraliser was loaded, this test was not run at all, due to its@skip_if_no_ultraliser
decorator. Based on the lack of mention of the substring "ultra" in testing output like https://github.com/BlueBrain/atlas-placement-hints/actions/runs/7698187655/job/20976910013 , I suspect that many CI tests are being skipped due to the lack of an Ultraliser install in the test environments.I hope I'm wrong about this, but it's one possible explanation for why this test that relies on Ultraliser seems to fail currently, but was not caught during the Ultraliser version update PR here https://github.com/BlueBrain/atlas-placement-hints/pull/18 .