search

BlueBrain / atlas-placement-hints

Tools to compute placement hints in the context of brain atlases.
Apache License 2.0
1 stars 2 forks source link

Hotfix: Add arg detection for overloading #26

Closed asoplata closed 1 month ago

asoplata commented 1 month ago

This fixes #25 by customizing the calls to the overloaded function compute_distances_to_layer_boundaries. Since there is only one definition of compute_placement_hints, this should solve the problem in all cases. This has been tested against the exact command and data that @lecriste provided in #25 along with some other cases, and all tox tests have passed locally.

arnaudon commented 1 month ago

Could you merge that? thanks!

mgeplf commented 1 month ago

Could you merge that? thanks!

I haven't had a chance to make some changes - I'd prefer that None was used as the sentinel instead of an empty string, as an empty string is an allowable directory. I should be able to do it tomorrow.

arnaudon commented 1 month ago

Ok, np!

mgeplf commented 1 month ago

I haven't had time to refactor this, I will do it in another commit. In the mean time, I will approve this, merge it and make a release.