BBPP134-1942 adding back ab and 2/3 special case regex

BlueBrain / atlas-placement-hints

Tools to compute placement hints in the context of brain atlases.

Apache License 2.0

1 stars 2 forks source link

BBPP134-1942 adding back ab and 2/3 special case regex #27

Closed jdcourcol closed 1 month ago

jdcourcol commented 1 month ago

as discussed in https://bbpteam.epfl.ch/project/issues/browse/BBPP134-1942

lecriste commented 1 month ago

Shall we add a test as @arnaudon mentioned here?

jdcourcol commented 1 month ago

I am not sure if the last "?" is needed or not.

mgeplf commented 1 month ago

I am not sure if the last "?" is needed or not.

Do you mean in "@^(?!SSp-bfd-[A-Z][0-9]$).*6[ab]?$"]? In the current hierarchy, there is only 6a and 6b; so technically not needed. I'm sure it will bite us in the future not having it though :(