The new RocksDB boolean configuration key create_missing_column_families drastically simplifies how the database is configured when created.
Removing this chunk of code also gets rid of a bug. An error was silently ignored when RocksDB wasn't linked with snappy but was specified in the database configuration. It led to other errors later...
This PR also makes sure the Basalt graph objects remain in a sane state when an error occurs when opening a RocksDB database.
Changes
The new RocksDB boolean configuration key
create_missing_column_familiesdrastically simplifies how the database is configured when created.Removing this chunk of code also gets rid of a bug. An error was silently ignored when RocksDB wasn't linked with snappy but was specified in the database configuration. It led to other errors later...
This PR also makes sure the Basalt graph objects remain in a sane state when an error occurs when opening a RocksDB database.
For reviewers
PLEASE IGNORE FORMATTING CHANGES IN CMake FILES https://github.com/BlueBrain/basalt/pull/107/files?file-filters%5B%5D=.cpp&file-filters%5B%5D=.hpp&file-filters%5B%5D=.py&file-filters%5B%5D=No+extension