search

BlueBrain / basalt

C++11 Graph Storage library
https://bluebrain.github.io/basalt
GNU Lesser General Public License v3.0
4 stars 2 forks source link

circuit payload type should not depend on Python #31

Closed tristan0x closed 5 years ago

tristan0x commented 5 years ago

For now, classes defined in src/basalt/circuit_payload depends on pybind11. It prevents unit-tests of these types because it is not possible to link against the pybind11 shared library.

pybind11 specific code should be defined elsewhere.

tristan0x commented 5 years ago

unit-test can now properly links against the shared library built by pybind11 since the SHARED flag is given to pybind11_add_module https://github.com/tristan0x/basalt/blob/981f9e658d986b1c9196b4c8eaf676eda6b89007/src/CMakeLists.txt#L50-L53

It is now possible to test these classes.