BlueBrain / bluepyentity

Manage entities within the knowledge graph
Apache License 2.0
5 stars 0 forks source link

Add the SNAP nexus implementation #3

Closed joni-herttuainen closed 2 years ago

joni-herttuainen commented 2 years ago

Short summary:

I think it would be a good start for everyone to add their code in the repo to have an overall picture of what we've got. Then, unifying common terminology as well as finding and putting the common functionality into a core class or equivalent becomes easier.

joni-herttuainen commented 2 years ago

ah, I can only add 1 reviewer?

mgeplf commented 2 years ago

ah, I can only add 1 reviewer?

I hope not, looks like I can, not sure why you can't.

joni-herttuainen commented 2 years ago

It shows me this: image And when I try to add another, it replaces the reviewer. 🤷‍♂️

eleftherioszisis commented 2 years ago

I believe this is because the repo is private. I experienced something similar before making vascpy public.

joni-herttuainen commented 2 years ago

alright I'll add rest of the reviewers like so: @GianlucaFicarelli , @jdcourcol , @eleftherioszisis , @DrTaDa , @genric

DrTaDa commented 2 years ago

Looks good to me

jdcourcol commented 2 years ago

LGTM