BlueBrain / diameter-synthesis

Synthesize diameters of neuronal morphologies
Apache License 2.0
3 stars 2 forks source link

bug in apical diametrizer #16

Closed arnaudon closed 2 years ago

arnaudon commented 2 years ago

The children sections of the last apical section had their diameters considered as asymmetrical, but assigned randomly on the children, thus creating a random extra thick trunk section. Now if no children of a trunk section are trunks, we generate symmetrical diameters.

adrien-berchet commented 2 years ago

Indeed, good catch :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (98014c8) into main (9bc4720) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   85.18%   85.21%   +0.02%     
==========================================
  Files          11       11              
  Lines        1107     1109       +2     
  Branches      235      236       +1     
==========================================
+ Hits          943      945       +2     
  Misses        119      119              
  Partials       45       45              
Flag Coverage Δ
pytest 85.21% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
diameter_synthesis/build_diameters.py 89.86% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bc4720...98014c8. Read the comment docs.

arnaudon commented 2 years ago

@adrien-berchet , your if broke the coverage...

arnaudon commented 2 years ago

I don't want to add a test, and I don't know how to handle this codecov dude :P