BlueBrain / diameter-synthesis

Synthesize diameters of neuronal morphologies
Apache License 2.0
3 stars 2 forks source link

bug with trifurcations #18

Closed arnaudon closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #18 (563777e) into main (8be3723) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   85.21%   85.23%   +0.02%     
==========================================
  Files          11       11              
  Lines        1109     1111       +2     
  Branches      236      236              
==========================================
+ Hits          945      947       +2     
  Misses        119      119              
  Partials       45       45              
Flag Coverage Δ
pytest 85.23% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
diameter_synthesis/build_diameters.py 89.95% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8be3723...563777e. Read the comment docs.

adrien-berchet commented 2 years ago

Are trifurcations allowed in valid morphs? I thought only bifurcations were valid.

arnaudon commented 2 years ago

some reconstructions have them, but our code support it, but in the wrong way, so better to have it supported properly

adrien-berchet commented 2 years ago

ok