simpler diametrizer

[arnaudon]

@adrien-berchet , also when you have time!

[arnaudon]

arg, I messed up the tests, there was some missing assert, so thing were not tested, I'll try to fix tonight

[adrien-berchet]

Ok, ping me again when it is fixed :-)

[arnaudon]

sorry, it's a huge mess, because the test had missing assert compar_dicts, so the input data was not tested and was wrong on disk, then the diamtrized test were also wrong wrt correct input data. I also changed a few things like basal-> basal_dendrite to avoid using the dict mapping

[codecov[bot]]

Codecov Report

Merging #22 (9fa099d) into main (10e8b79) will decrease coverage by 2.23%. The diff coverage is 71.14%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   85.23%   83.00%   -2.24%     
==========================================
  Files          11       12       +1     
  Lines        1111     1224     +113     
  Branches      236      264      +28     
==========================================
+ Hits          947     1016      +69     
- Misses        119      162      +43     
- Partials       45       46       +1     

Flag	Coverage Δ
pytest	83.00% <71.14%> (-2.24%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
diameter_synthesis/main.py	55.04% <10.00%> (-9.61%)	:arrow_down:
diameter_synthesis/simpler_diametrizer.py	75.25% <75.25%> (ø)
diameter_synthesis/build_diameters.py	90.04% <87.50%> (+0.09%)	:arrow_up:
diameter_synthesis/build_models.py	100.00% <100.00%> (ø)
diameter_synthesis/cli.py	85.91% <100.00%> (ø)
diameter_synthesis/morph_functions.py	97.63% <100.00%> (ø)
diameter_synthesis/plotting.py	83.52% <100.00%> (-2.36%)	:arrow_down:
diameter_synthesis/distribution_fitting.py	97.53% <0.00%> (+2.46%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[arnaudon]

@adrien-berchet , did you get a chance to have a look at that? No big rush, just to know/plan work.

[adrien-berchet]

@adrien-berchet , did you get a chance to have a look at that? No big rush, just to know/plan work.

Ah no, I forgot about this one, sorry. I will very soon!