Closed olupton closed 2 years ago
https://github.com/neuronsimulator/nrn/pull/1738 added configuration for a black pre-commit look in NEURON, which means that there is now a .pre-commit-config.yaml file in NEURON.
black
.pre-commit-config.yaml
https://github.com/BlueBrain/hpc-coding-conventions/blob/eefdc3889876efcfbbdfd820e62ad8c11ffa005e/cpp/CMakeLists.txt#L346-L350 implies that, regardless of the _GIT_HOOKS variable, either cpp_cc_enable_precommit() or cpp_cc_disable_precommit() will be called.
_GIT_HOOKS
cpp_cc_enable_precommit()
cpp_cc_disable_precommit()
cpp_cc_disable_precommit() modifies this YAML file: https://github.com/BlueBrain/hpc-coding-conventions/blob/eefdc3889876efcfbbdfd820e62ad8c11ffa005e/cpp/CMakeLists.txt#L47-L56
which in NEURON leads to confusing diffs: https://github.com/neuronsimulator/nrn/pull/1746#issuecomment-1081996907.
hpc-coding-conventions should not be meddling with files that are committed to repositories like this.
https://github.com/neuronsimulator/nrn/pull/1738 added configuration for a
blackpre-commit look in NEURON, which means that there is now a.pre-commit-config.yamlfile in NEURON.https://github.com/BlueBrain/hpc-coding-conventions/blob/eefdc3889876efcfbbdfd820e62ad8c11ffa005e/cpp/CMakeLists.txt#L346-L350 implies that, regardless of the
_GIT_HOOKSvariable, eithercpp_cc_enable_precommit()orcpp_cc_disable_precommit()will be called.cpp_cc_disable_precommit()modifies this YAML file: https://github.com/BlueBrain/hpc-coding-conventions/blob/eefdc3889876efcfbbdfd820e62ad8c11ffa005e/cpp/CMakeLists.txt#L47-L56which in NEURON leads to confusing diffs: https://github.com/neuronsimulator/nrn/pull/1746#issuecomment-1081996907.
hpc-coding-conventions should not be meddling with files that are committed to repositories like this.