Rework formatters - Githubissues

BlueBrain / hpc-coding-conventions

Apache License 2.0

8 stars 5 forks source link

Rework formatters #115

Closed alkino closed 2 years ago

alkino commented 2 years ago

Delete partial check and format for clang-format
Filters are now relative to the directory
Use git ls-tree instead of cmake-compile.json file

Removed CMake options:

{PROJECT_NAME}_FORMATTING_ON
[PROJECT_NAME]_FORMATTING_CPP_CHANGES_ONLY
[PROJECT_NAME}_FORMATTING_NO_SUBMODULES

Removed python options:

-B
--git-modules
--applies-on
--changes-only
--clang-format-diff-executables

Closes https://github.com/BlueBrain/hpc-coding-conventions/issues/104.

alkino commented 2 years ago

You can see usage here: https://github.com/BlueBrain/nmodl/pull/836 And here: https://github.com/BlueBrain/CoreNeuron/pull/794

alkino commented 2 years ago

So @tristan0x you are against removing the partial check/format?

tristan0x commented 2 years ago

I am using this option, please keep it for now. git-clang-format didn't exist when --applies-on has been added. I am ok to remove it only when this project switches to git-clang-format

On second thought, let's nuke that part of the code.

alkino commented 2 years ago

nmodl and coreneuron works well with this new simplified version

alkino commented 2 years ago

I will merge it at 2pm if no one complains before