BlueBrain / hpc-coding-conventions

Apache License 2.0
8 stars 5 forks source link

Add an option to set the option prefix #69

Closed ohm314 closed 4 years ago

ohm314 commented 4 years ago

in some projects, the ${PROJECT_NAME} variable differs from what we ususally have as the prefix for cmake options. For example:

This change allows the programmer to define their own prefix, which can later be used for the variables when building the project.

matz-e commented 4 years ago

This patch increases the complexity of the code maintenance. I understand that this would allow neuron and coreneuron options to be named consistently but can't these projects take the responsibility of their inherent inconsistency instead?

I think that the increase in complexity is actually fairly small (setting the option), and it may allow to truncate very elaborate project names (coreneuron is still kind of small, someone may come up with coreneuron-bglibcpp or so). I'd actually be in favor of this. I would like to be able to grok my command lines and not have to parse ELABORATE_project_NAME_WITH_useless_SUFFIX_COMPILE_OPTIONS all the time

pramodk commented 4 years ago

I also agree with above - for open source projects where it’s difficult to change options/name, this will be very useful. And, as hpc coding convention will serve as common base for many projects, such flexibility might be helpful beyond NEURON/CoreNEURON.