BlueBrain / libsonatareport

Other
2 stars 2 forks source link

Remove MPI_COMM_WORLD references #27

Open jorblancoa opened 2 years ago

jorblancoa commented 2 years ago

The main communicator should be received as parameter from the simulator.

A good place would be to add an extra parameter in the sonata_setup_communicators(MPI_Comm main_comm) method https://github.com/BlueBrain/libsonatareport/blob/77d5d9267ac0f1a15d46affd0e48a0fb5cc7a7a7/src/library/reports.cpp#L69

CoreNEURON and py-neurodamus core submodule would need to be adapted also: https://github.com/BlueBrain/CoreNeuron/blob/d0cf5503f1f41fb7d313722e800e306a596bd3b3/coreneuron/io/reports/nrnreport.cpp#L63 https://bbpgitlab.epfl.ch/hpc/sim/neurodamus-core/-/blob/main/mod/SonataReportHelper.mod#L86