BlueBrain / morph-tool

https://morph-tool.readthedocs.org/
GNU Lesser General Public License v3.0
8 stars 7 forks source link

multiple point to isec converter #10

Closed arnaudon closed 4 years ago

arnaudon commented 4 years ago

This is a proposal PR to allow for converting a list of 3d points to a list of neuron isections with multiprocessing. This can be used to process a large number of morphologies, and requires each computation to be isolated to prevent NEURON clashes with itself.

Things to do/discuss:

arnaudon commented 4 years ago

So you don't want to keep the isection converter here? Tbh, I think it is better to not have to do this step, and only record the coordinate of apical point, and convert to whatever is needed wherever it is needed. So we could update the PR purpose.

For isolate, I need to double check, but I think NestedPool is not needed to isolate, but only to run the isolated functions in parallel. I have now a dask setup for running isolated functions in parallel, which only needs a config modification rather than this NestedPool.

arnaudon commented 4 years ago

Ah sorry, I forgot about that one, you can merge as it is, I think it is fine. The apical point thing will be done differently anyway.