search

BlueBrain / morph-tool

https://morph-tool.readthedocs.org/
GNU Lesser General Public License v3.0
8 stars 7 forks source link

morphio_diff.diff should handle different somas #26

Open asanin-epfl opened 4 years ago

asanin-epfl commented 4 years ago

My proposition would be to raise an error if two morphologies have somas which are not single points. Otherwise the function is misleading because it does not compare somas. Such assumption works only for single point somas.

wizmer commented 4 years ago

That would make the function almost useless. Alternatively, we could do the following: If both file comes from the same file format, then compare soma. If they have a different file format (and hence a different soma representation), compare soma surface. What do you think ? In which context did you get mislead by the function ?

asanin-epfl commented 4 years ago

If they have a different file format (and hence a different soma representation), compare soma surface.

Need a scientist opinion on that.

In which context did you get mislead by the function ?

The misleading is that somas are not compared currently.