search

BlueBrain / morph-tool

https://morph-tool.readthedocs.org/
GNU Lesser General Public License v3.0
8 stars 7 forks source link

Allow to pass numpy rangom generators to graft_axon #69

Closed adrien-berchet closed 3 years ago

adrien-berchet commented 3 years ago

Context

In region-grower we use Numpy random generator objects instead of the global numpy.random. We need to pass these objects to graft_axon as there is a random generation in grafting_position.

Resolution

This PR adds new parameters to allow to pass a random number generator. If nothing is passed, numpy.random is used, so it is not a breaking change.

arnaudon commented 3 years ago

@mgeplf , I think aleksei is going on vacation, could you help us merge this, it is blocking the release of region-grower for NCx. I't part of an effort of adrien to make our codes more reproducible/stable wrt random numbers and parallelization. Thank you!

arnaudon commented 3 years ago

Ah, I can merge here! Let see if I can release as well!

asanin-epfl commented 3 years ago

@arnaudon the version of the new release must be 2.5.0 because it also includes #54 which you forgot to mention the release's notes. Delete 2.4.5 release. Release the correct 2.5.0.

arnaudon commented 3 years ago

ah but this is not breaking, it is a new feature only.

arnaudon commented 3 years ago

ok, I updated it, I hope it works