search

BlueBrain / morph-tool

https://morph-tool.readthedocs.org/
GNU Lesser General Public License v3.0
8 stars 7 forks source link

use isclose in spatial #84

Closed arnaudon closed 3 years ago

arnaudon commented 3 years ago

Context

In one instance, this failed as strict equalities were not working with rounding errors.

Resolution

np.isclose solves it

arnaudon commented 3 years ago

I did rubish, now it's better!

arnaudon commented 3 years ago

Test are breaking, but it's not my fault :P

asanin-epfl commented 3 years ago

yes, the fix is in my PR #82 , so I suggest one of you approves it.

adrien-berchet commented 3 years ago

Maybe you can just improve the test_point_to_section_segment() test to add some cases with rtol and atol?

arnaudon commented 3 years ago

Maybe you can just improve the test_point_to_section_segment() test to add some cases with rtol and atol?

baaaaaah

asanin-epfl commented 3 years ago

baaaaaah

Is it yes or no? Should we wait for additional tests as Adrien suggested?

asanin-epfl commented 3 years ago

Anyway I expect from you a note in CHANGELOG.rst

arnaudon commented 3 years ago

Here you are!

arnaudon commented 3 years ago

All good then?