Closed FrancescoCasalegno closed 2 years ago
The build system of a Python package is specified in the pyproject.toml file. We need setuptools and wheels to build our package, and for this reason we have those dependencies there: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/pyproject.toml#L1-L7
pyproject.toml
setuptools
wheels
But then in the install.sh script we explicitly specify the installation of these two same packages: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/install.sh#L3-L4
install.sh
These lines in install.sh seem therefore to be redundant.
Remove the following lines from install.sh, after making sure that nothing gets broken: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/install.sh#L3-L4
Context
The build system of a Python package is specified in the
pyproject.toml
file. We needsetuptools
andwheels
to build our package, and for this reason we have those dependencies there: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/pyproject.toml#L1-L7But then in the
install.sh
script we explicitly specify the installation of these two same packages: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/install.sh#L3-L4These lines in
install.sh
seem therefore to be redundant.Action
Remove the following lines from
install.sh
, after making sure that nothing gets broken: https://github.com/BlueBrain/morphoclass/blob/72f59fad5dca9eb08a5752a21de7577c47f1011b/install.sh#L3-L4