Replay with NetCons in CoreNEURON as in NEURON - Githubissues

BlueBrain / neurodamus

A BBP Simulation Control application for NEURON

https://neurodamus.readthedocs.io

Apache License 2.0

9 stars 8 forks source link

Replay with NetCons in CoreNEURON as in NEURON #173

Closed WeinaJi closed 5 months ago

WeinaJi commented 6 months ago

Context

Currently Neurodamus uses different spike replay processes for NEURON and CoreNEURON:

For NEURON, it creates NetCons between a Vectim and the post synaptic object
For CoreNeuron, it writes the spikes into a .dat file and passes it to CoreNEURON via "–pattern" CLI h

For the feature of running CoreNEURON in memory, we need to unify the synapse replay for both simulators. This PR makes CoreNEURON to replay as NEURON, using NetCons and VecStim. NetCons should be transferable between Neuron and CoreNEURON.

Scope

In node.py, remove _coreneuron_replay_append for writing out replay data file. Call the same replay function for CoreNEURON.
In connection_manager.py, no attach_src for coreneuron virtual source. replay_mode from ReplayMode.NONE -> ReplayMode.AS_REQUIRED for coreneuron
In neuromodulation_manager.py, similar changes

Testing

Current tests

Review

[x] PR description is complete
[x] Coding style (imports, function length, New functions, classes or files) are good
[x] Unit/Scientific test added
[ ] Updated Readme, in-code, developer documentation

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #212923 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #213492 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #213527 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #213810 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #213881 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 5 months ago

Logfiles from GitLab pipeline #215914 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 5 months ago

Logfiles from GitLab pipeline #218695 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 5 months ago

Logfiles from GitLab pipeline #218697 (:no_entry:) have been uploaded here!

Status and direct links: