search

BlueBrain / neurodamus

A BBP Simulation Control application for NEURON
https://neurodamus.readthedocs.io
Apache License 2.0
9 stars 8 forks source link

Switch astrocyte mod file from mcd to cadifus. #193

Closed WeinaJi closed 2 months ago

WeinaJi commented 2 months ago

Cloned from Dan's forked branch https://github.com/dkeller9/neurodamus/tree/patch-1

Context

The old mcd file should be replaced by cadifus, which has new mechanisms for astrocyte diffusion.

Scope

ngv.py was changed to insert a different mod file.

Testing

Review

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228461 (:no_entry:) have been uploaded here!

Status and direct links:

WeinaJi commented 2 months ago

Hello @dkeller9 , I have cloned your forked branch https://github.com/dkeller9/neurodamus/tree/patch-1 and push to the neurodamus repo so that we can enable our gitlab CI tests. Could you please double check if your changes are all included in this PR? I will close https://github.com/BlueBrain/neurodamus/pull/192 and use this one for code review.

WeinaJi commented 2 months ago

I am investigating the github test errors.

dkeller9 commented 2 months ago

Yes, the changes are included in this new fork.

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228575 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228603 (:white_check_mark:) have been uploaded here!

Status and direct links:

dkeller9 commented 2 months ago

Okay, I restored the print statements and added an explanation for why things are commented in the branch

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228795 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228832 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228835 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228857 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #228961 (:white_check_mark:) have been uploaded here!

Status and direct links:

WeinaJi commented 2 months ago

Apparently I can't approve the PR as the "author". @dkeller9 @matz-e , if it looks ok for you, please press the button.

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #229120 (:white_check_mark:) have been uploaded here!

Status and direct links:

dkeller9 commented 2 months ago

LGTM