Synapse reading fixes - Githubissues

BlueBrain / neurodamus

A BBP Simulation Control application for NEURON

https://neurodamus.readthedocs.io

Apache License 2.0

9 stars 8 forks source link

Synapse reading fixes #197

Closed ferdonline closed 2 months ago

ferdonline commented 2 months ago

Context

Fix an issue reading extra properties for cells where there are no synapses.

Error:

conn_syn_params[name] = data[name]
E           KeyError: 'weight'

Scope

After recent optimizations, we dont create empty base properties. Therefore, extended empty properties must not be created either.
We must ensure that when a gid is assigned EMPTY_DATA it is not considered, otherwise it would even ruin the shared empty dict.

Testing

wip..

Review

[x] PR description is complete
[x] Coding style (imports, function length, New functions, classes or files) are good
[x] Unit/Scientific test added
[ ] Updated Readme, in-code, developer documentation

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #234592 (:white_check_mark:) have been uploaded here!

Status and direct links: