search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Pycodestyle #237

Closed mgeplf closed 9 months ago

mgeplf commented 2 years ago

I did a pass on the linting so that the pycodestyle checks would pass (w/ a large line-length). I also enabled them in the github actions.

Having the pylint checks enabled would be very nice; especially filling out the missing docstrings. However, I can't do that, since I don't have the knowledge about the expected behavior.

mgeplf commented 2 years ago

Any chance this can be integrated? The long it stays unmerged, the more work it is to get it back to working state. Thanks.

crisely09 commented 1 year ago

This PR was opened before I joined, I noticed it a few days ago and I would like to merge it, but I wonder : @mgeplf are you still interested in merging this branch?

mgeplf commented 1 year ago

Yeah, I think it's worth adding linting to the project, as I find it catches many mistakes. I would, personally, make it manditory, but that might require a bunch of cleanup.

ssssarah commented 10 months ago

Should this MR be closed? https://github.com/BlueBrain/nexus-forge/pull/352 this one was recently merged implementing the pycodestyle check @mgeplf @MFSY

mgeplf commented 10 months ago

Happy that more linting has been added in #352; I'll close this. Thanks @ssssarah

ssssarah commented 9 months ago

I'll close this :)